Skip to content

Corrected Building.md and added additional content. #60167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Corrected Building.md and added additional content. #60167

wants to merge 2 commits into from

Conversation

@moluopro
Copy link
Contributor

@moluopro moluopro commented Feb 19, 2025 •
edited
Loading

The following error or outdated content have been fixed:

  1. none is not an allowed value for option --compiler.
  2. --report and --checked are no longer in use.
moluo@ubuntu:~/work/dart-sdk/sdk$ ./tools/test.py \
  --compiler none \
  --runtime vm \
  --progress color \
  --arch x64 \
  --mode release \
  --checked \
  --report \
  --time \
  --tasks 6 \
  language
"none" is not an allowed value for option "--compiler".
moluo@ubuntu:~/work/dart-sdk/sdk$ ./tools/test.py --help | grep report
moluo@ubuntu:~/work/dart-sdk/sdk$ ./tools/test.py --help | grep check
moluo@ubuntu:~/work/dart-sdk/sdk$

Added some explanations for the parameters of test.py in Building.md. Additionally, a small section on cross-compilation test-items has been added to Building-Dart-SDK-for-ARM-or-RISC-V.md.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Contributions to our repos should follow the Dart style guide and use dart format.

@copybara-service
Copy link

copybara-service bot commented Feb 19, 2025

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/410446

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@copybara-service
Copy link

copybara-service bot commented Feb 19, 2025

https://dart-review.googlesource.com/c/sdk/+/410446 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

copybara-service bot commented Feb 26, 2025

https://dart-review.googlesource.com/c/sdk/+/410446 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service
Copy link

copybara-service bot commented Feb 26, 2025

https://dart-review.googlesource.com/c/sdk/+/410446 has been updated with the latest commits from this pull request.

@moluopro moluopro mentioned this pull request Feb 28, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@moluopro